New features/killqt4 branch (was: Re: [Qt4???] Re: [PATCH] Show branches from master document in branch inset dialog)

[Scott Kostyshak]

On Fri, Nov 18, 2022 at 05:33:43PM +0100, Jean-Marc Lasgouttes wrote:
> Le 17/11/2022 à 07:34, Jürgen Spitzmüller a écrit :
> > Am Mittwoch, dem 16.11.2022 um 11:11 -0500 schrieb Scott Kostyshak:
> > > Does anyone object then to supporting only Qt5 for
> > > 2.4.0 (and forward)?
> > 
> > No. I think now is the time to do it.
> 
> I created a new branch killqt4

Judging by the name, I see that Qt4 has caused you some pain :)

> that removes #ifdefs in src and adds a TODO
> list in TODO.killqt4.

Great, Thank you for doing this on a branch!

> There are also FIXME KILLQT4 entries for things that we should investigate.

Perfect.

> What can you do to help?
> * have look at the diff in src to spot what I broke
> * and look at KILLQT4 annotations to see whethe rsome of them are in your
> ballpark
> * look for things to do in TODO.killqt4

I think this was meant for Jürgen, but to be clear I'm hoping to not do
anything :)

Well, I am happy to check whether the branch compiles for me on a couple
of different systems.

> If you prefer, I can do that directly in master.

I would prefer the branch if that's OK.

Thanks for you work on this cleanup!

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20221118/796af398/attachment.asc>