[LyX/master] Fix ToC action when cursor is in adv. F&R pane
Kornel Benko
kornel at lyx.org
Thu Jun 30 10:19:29 UTC 2022
Am Thu, 30 Jun 2022 12:11:36 +0200
schrieb Jean-Marc Lasgouttes <lasgouttes at lyx.org>:
> Le 30/06/2022 à 11:57, Kornel Benko a écrit :
> > For your info.
> > Make a breakpoint at FindAndReplaceWidget::eventFilter
> > Starting the findadv-dialog causes 128 calls to that routine with totally different
> > stack counts.
> > (using 'bt -3')
>
> Several points here:
>
> 1/ it is not really a problem that eventFilter is called many times,
> since many types of events may happen
>
> 2/ eventFilter() should be a keyPressEvent in my opinion. We are only
> interested in key events.
>
> 3/ adding a updateGUI here (my doing at c30b0aac4bd) was a very very bad
> idea
>
> Point 3/ is probably the core reason for the bug, together with 2/.
>
> I propose to apply my patch for now, since it makes sense in itself. But
> I will investigate the rest.
>
> JMarc
+1
Kornel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20220630/f526825c/attachment.asc>
More information about the lyx-devel
mailing list