[LyX/master] Fix ToC action when cursor is in adv. F&R pane

Jean-Marc Lasgouttes lasgouttes at lyx.org
Thu Jun 30 10:11:36 UTC 2022


Le 30/06/2022 à 11:57, Kornel Benko a écrit :
> For your info.
> Make a breakpoint at FindAndReplaceWidget::eventFilter
> Starting the findadv-dialog causes 128 calls to that routine with totally different stack
> counts.
> (using 'bt -3')

Several points here:

1/ it is not really a problem that eventFilter is called many times, 
since many types of events may happen

2/ eventFilter() should be a keyPressEvent in my opinion. We are only 
interested in key events.

3/ adding a updateGUI here (my doing at c30b0aac4bd) was a very very bad 
idea

Point 3/ is probably the core reason for the bug, together with 2/.

I propose to apply my patch for now, since it makes sense in itself. But 
I will investigate the rest.

JMarc


More information about the lyx-devel mailing list