Failure to compile with gcc-12 (2.3.x)

[Jean-Marc Lasgouttes]

Le 27/01/2022 à 14:09, Scott Kostyshak a écrit :
> On Thu, Jan 27, 2022 at 01:04:12PM +0000, José Abílio Matos wrote:
>> Hi,
>>    we are at the time of year again. :-)
>>
>> The gcc project will release version 12 and in Fedora we are rebuilding all
>> packages with it.
>>
>> There is a failure to build 2.3.x (e.g. on x86-54):
>> https://kojipkgs.fedoraproject.org//work/tasks/4412/81984412/build.log
>>
>>     73 | class MatchString : public binary_function<Paragraph, pos_type, int>

This one is a warning, but you cut part of it out.

>>        |                            ^~~~~~~~~~~~~~~
>> In file included from /usr/include/c++/12/string:48,
>>                   from support/strfwd.h:42,
>>                   from lyxfind.h:19,
>>                   from lyxfind.cpp:17:
>> /usr/include/c++/12/bits/stl_function.h:131:12: note: declared here
>>    131 |     struct binary_function
>>        |            ^~~~~~~~~~~~~~~
>> lyxfind.cpp: In function 'bool lyx::{anonymous}::regex_replace(const std::string&, std::string&, const std::string&, const std::string&)':
>> lyxfind.cpp:677:9: error: 'ostream_iterator' was not declared in this scope
>>    677 |         ostream_iterator<char, char> it(oss);
>>        |         ^~~~~~~~~~~~~~~~
>> lyxfind.cpp:55:1: note: 'std::ostream_iterator' is defined in header '<iterator>'; did you forget to '#include <iterator>'?
>>     54 | #include "support/regex.h"
>>    +++ |+#include <iterator>

Yes, sure.

> Except for that issue does it build with -Werror ?

2.3.6 has many deprecation errors. Many of them are fixed in branch 
2.3.x, but not all.

And it seems there are some new warnings. Let's see what happens with 
our current branches.

José, what can you tell me about these messages?
annobin: Timeout.cpp: Warning: -D_GLIBCXX_ASSERTIONS not defined

We use _GLIBCXX_DEBUG currently. Should we switch to 
_GLIBCXX_ASSERTIONS? I have not found the gcc docs very useful in this 
respect.

JMarc