New Theorems Module

[Thibaut Cuvelier]

I've pushed your patch online: 42c2a25fb8. I had to rebase it manually, I
hope I didn't make too many mistakes. I'm also attaching the patch to this
email so that you can check it more easily if you want.

(If someone can add Udi to the blanket permissions, here is the link on the
mailing list: https://marc.info/?l=lyx-devel&m=165779733507955&w=2)

Thibaut Cuvelier


On Sat, 31 Dec 2022 at 01:00, Thibaut Cuvelier <dourouc05 at gmail.com> wrote:

> Hi,
>
> I'm jumping back in this discussion. There have been recent changes in the
> DocBook implementation of theorems. Instead of setting DocBookTag and
> DocBookAttr like this:
>
> DocBookTag            para
> DocBookAttr           role='theorem'
>
> we now use a wrapper to delimit theorems:
>
> DocBookWrapperTag     figure
> DocBookWrapperAttr    role='theorem'
> DocBookTag            para
> DocBookGenerateTitle  true
>
> For your other theorems, just update the line role= with the right kind of
> element (just like on master). I can take care of this step when merging
> your patch, as there seems to be some consensus around it.
>
> I noticed you asked whether anything was required for lists of theorems
> and the list: no, the DocBook processor is supposed to take care of that.
>
> As you gave permission to use your patch under the GPL in an earlier
> message (why isn't it listed on https://www.lyx.org/BlanketPermission?),
> I'm proceeding with integrating your patch :).
>
> All the best,
> Thibaut Cuvelier
>
>
> On Mon, 7 Nov 2022 at 23:29, Paul A. Rubin <parubin73 at gmail.com> wrote:
>
>> On 10/13/22 02:45, Udicoudco wrote:
>>
>>
>>
>> On Fri, Sep 23, 2022 at 12:25 AM Paul A. Rubin <parubin73 at gmail.com>
>> wrote:
>>
>>> On 9/19/22 22:26, Udicoudco wrote:
>>>
>>> I've noticed that the definition environment is not numbered in the
>>> output files. After checking the module again, I hope there are no
>>> issues any more. The fixed module is attached.
>>>
>>> Regards,
>>> Udi
>>>
>>>
>>> I noticed a new pathology with this version. Steps to reproduce are as
>>> follows:
>>>
>>>    1. Compile the test_thmtools_module.lyx document (which works fine).
>>>    2. Delete the entire contents of section 2, other than the section
>>>    heading, and recompile. I've attached the PDF I get. Note the garbled
>>>    contents where the theorem lists go.
>>>    3. Make any minor edit to the document (to force a fresh compile)
>>>    and recompile. The output is as expected.
>>>
>>> HTH,
>>>
>>> Paul
>>> --
>>>
>>
>> Hi Paul,
>>
>> Sorry for the late reply, it is the holiday season in my country.
>>
>> I've managed to solve this issue with a simple trick. The updated module
>> can be found in here <https://github.com/Udi-Fogiel/LyX-thmtools>.
>> If you will try it again, I would be glad to hear from you.
>>
>> Best Regards,
>> Udi
>>
>>> lyx-devel mailing list
>>> lyx-devel at lists.lyx.org
>>> http://lists.lyx.org/mailman/listinfo/lyx-devel
>>>
>>
>> Udi,
>>
>> Speaking of late replies, it's my turn to apologize. You posted this just
>> as I was heading out to a conference. Since getting back, I've been
>> (slowly) catching up on accumulated work.
>>
>> I just tested the updated module, and can confirm that the problem I
>> noticed is gone. Good job!
>>
>> Paul
>>
>> --
>> lyx-devel mailing list
>> lyx-devel at lists.lyx.org
>> http://lists.lyx.org/mailman/listinfo/lyx-devel
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20221231/7b5ee57d/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-New-Theorems-Module.-Contributed-by-Udicoudco-udifog.patch
Type: application/octet-stream
Size: 204244 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20221231/7b5ee57d/attachment-0001.obj>