DocBook change: use a stack of fonts

Scott Kostyshak skostysh at lyx.org
Wed Dec 28 03:03:56 UTC 2022


On Tue, Dec 27, 2022 at 07:36:41PM +0100, Kornel Benko wrote:
> Am Tue, 27 Dec 2022 10:23:59 -0500
> schrieb Scott Kostyshak <skostysh at lyx.org>:
> 
> > On Tue, Dec 27, 2022 at 10:12:15AM +0100, Kornel Benko wrote:
> > > Am Tue, 27 Dec 2022 00:03:40 -0500
> > > schrieb Scott Kostyshak <skostysh at lyx.org>:
> > >   
> > > > On Tue, Dec 27, 2022 at 02:13:15AM +0100, Thibaut Cuvelier wrote:  
> > > > > Dear list,
> > > > > 
> > > > > To solve https://www.lyx.org/trac/ticket/12585, I wrote the attached patch.
> > > > > Basically, LyX now considers the order of font tags when closing them,
> > > > > otherwise you get strange results like in the ticket. The bug is quite
> > > > > serious, actually, even though I don't believe many users will hit it.
> > > > > 
> > > > > I'd like help on two points:
> > > > > - code review
> > > > > - running the test suite (ctest -R "_docbook")    
> > > > 
> > > > Here are the failures:
> > > >   
> > > ...
> > > 
> > > Interesting ... here all these tests pass.  
> > 
> > They pass for you with the patch applied or without the patch? I was testing with the
> > patch.
> > 
> > Scott
> 
> Without the patch.

Good to know, same here. WIth the patch, I get the extra failures.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20221227/f8349ab2/attachment.asc>


More information about the lyx-devel mailing list