Master broken due to febd1855eb

[Scott Kostyshak]

On Wed, Dec 28, 2022 at 02:34:50AM +0100, Thibaut Cuvelier wrote:
> On Tue, 27 Dec 2022 at 23:41, Daniel <xracoonx at gmx.de> wrote:
> 
> > With febd1855eb ("XML: overhaul the tag-comparison operators."), I get
> >
> > /src/tex2lyx/dummy_impl.cpp:102:16: error: out-of-line
> >        definition of 'operator==' does not match any declaration in
> >        'lyx::xml::StartTag'
> > bool StartTag::operator==(FontTag const & rhs) const { return rhs ==
> > *this; }
> >                 ^~~~~~~~
> > /src/tex2lyx/dummy_impl.cpp:103:15: error: out-of-line
> >        definition of 'operator==' does not match any declaration in
> >        'lyx::xml::FontTag'
> > bool FontTag::operator==(StartTag const & tag) const { FontTag const * c...
> >                ^~~~~~~~
> >
> 
> I've just pushed 8b5bfa971b to fix this problem. (As this code was
> seemingly only necessary on Windows: tex2lyx now compiles just fine with
> VC19.) Sorry about that.

I have 8b5bfa971b pulled in but I get:

[ 97%] Building CXX object src/tests/CMakeFiles/check_layout.dir/dummy_functions.cpp.o
cd /home/scott/lyxbuilds/master-master/CMakeBuild/src/tests && /usr/lib/ccache/clang++ -DBOOST_USER_CONFIG="<config.h>" -DQT_CORE_LIB -DQT_GUI_LIB -I/home/scott/lyxbuilds/master-master/CMakeBuild -I/home/scott/lyxbuilds/master-master/repo/src -I/usr/include/enchant-2 -I/usr/include/hunspell -I/home/scott/lyxbuilds/master-master/repo/3rdparty/boost -I/home/scott/lyxbuilds/master-master/repo/3rdparty/nod -I/home/scott/lyxbuilds/master-master/CMakeBuild/src -I/home/scott/lyxbuilds/master-master/repo/src/support/tests -I/home/scott/lyxbuilds/master-master/repo/src/tests -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -Wall -Wextra -Wno-deprecated-copy --std=c++20 -Wno-deprecated-register -fno-strict-aliasing  -O0 -g3 -D_DEBUG   -Werror -fPIC -std=c++20 -MD -MT src/tests/CMakeFiles/check_layout.dir/dummy_functions.cpp.o -MF CMakeFiles/check_layout.dir/dummy_functions.cpp.o.d -o CMakeFiles/check_layout.dir/dummy_functions.cpp.o -c /home/scott/lyxbuilds/master-master/repo/src/tests/dummy_functions.cpp
/home/scott/lyxbuilds/master-master/repo/src/tests/dummy_functions.cpp:56:16: error: out-of-line definition of 'operator==' does not match any declaration in 'lyx::xml::StartTag'
bool StartTag::operator==(FontTag const & rhs) const { return rhs == *this; }
               ^~~~~~~~
/home/scott/lyxbuilds/master-master/repo/src/tests/dummy_functions.cpp:57:17: error: out-of-line definition of 'operator==' does not match any declaration in 'lyx::xml::FontTag'
  bool FontTag::operator==(StartTag const & tag) const { FontTag const * const ftag = tag.asFontTag();   if (!ftag) return false; return (font_type_ == ftag->font_type_); }
                ^~~~~~~~
2 errors generated.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20221227/d0b934a8/attachment-0001.asc>