master compile errors gzlib?

[Scott Kostyshak]

On Fri, Dec 16, 2022 at 10:42:07PM +0100, Yu Jin wrote:
> Am Fr., 16. Dez. 2022 um 21:47 Uhr schrieb Scott Kostyshak:
> 
> > On Fri, Dec 16, 2022 at 09:18:08PM +0100, Yu Jin wrote:
> > > Done at 26a3a085
> >
> > Sorry for the late comment Yu Jin, but should that line be conditional
> > on (not?) LYX_EXTERNAL_Z?
> >
> > I'm guessing that the answer is that it's only necessary if
> > LYX_EXTERNAL_Z is OFF, but that if LYX_EXTERNAL_Z is ON, it doesn't
> > hurt? If this is indeed the answer, I think I would still be in favor of
> > adding the conditional, although not a strong opinion.
> 
> 
> sounds plausible actually. How do I use external Zlib though? I mean Qt
> does not seem to have a zlib.lib somewhere in the kit, so including Qts
> zlib.h does not make sense then either. Would I have to compile my own
> zlib.lib separately and use the corresponding zlib.h? Then I would also not
> need QtZlib, indeed I would also get the same error if I compiled a
> different zlib.lib version then Qts zlib.h... As I already wrote, the whole
> thing seems kinda suspicious. The variable is called
> _Qt6ZlibPrivate_OWN_INCLUDE_DIRS, "private" suggests like it is just for
> Qt, not for the application which uses Qt (like LyX), so why does it
> include it in LyX in the first place?
> I mean I don't know, as I wrote my commit was a workaround rather than a
> solution...

Good questions, I have no idea about external Zlib. I just noticed the
external option when grepping.

Good point about "Private".

I retract my suggestion: I think we should just go with what you already
did, since we know that works. And since as you mention this is kind of
a workaround so no need to polish it.

I added a simple comment at f9178fa2. Adapt if you wish. Otherwise,
let's just move on and hope this workaround continues to work.

Thanks for figuring out a workaround for this mystery!

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20221218/8a5646ec/attachment.asc>