master compile errors gzlib?

[Scott Kostyshak]

On Fri, Dec 16, 2022 at 09:18:08PM +0100, Yu Jin wrote:
> Am Fr., 16. Dez. 2022 um 09:16 Uhr schrieb Kornel Benko :
> 
> > Am Fri, 16 Dec 2022 07:37:00 +0100
> > schrieb Yu Jin:
> >
> > > > Yes it does work, but actually I had a better idea to use
> > > > ${_Qt6ZlibPrivate_OWN_INCLUDE_DIRS} instead of
> > "${CMAKE_PREFIX_PATH}/include/QtZlib",
> > > > because it is in the variable already. I have sent a patch here:
> > > > https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg218797.html
> > can you test it
> > > > again, it contains 2 more changes, but you can ignore those, they only
> > affect
> > > > wininstaller. Then I can push it if it still works for linux.
> > > >
> > > Here is a separate patch for just the CMake part.
> > >
> >
> > +1 to commit
> 
> 
> Done at 26a3a085

Sorry for the late comment Yu Jin, but should that line be conditional
on (not?) LYX_EXTERNAL_Z?

I'm guessing that the answer is that it's only necessary if
LYX_EXTERNAL_Z is OFF, but that if LYX_EXTERNAL_Z is ON, it doesn't
hurt? If this is indeed the answer, I think I would still be in favor of
adding the conditional, although not a strong opinion.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20221216/145f7ee9/attachment-0001.asc>