[LyX/master] Comment

Scott Kostyshak skostysh at lyx.org
Sat Dec 3 00:38:29 UTC 2022


On Sat, Dec 03, 2022 at 12:39:18AM +0100, Scott Kostyshak wrote:
> commit c7269ffa8639ad1c8dac01997bd2117e5cfde96c
> Author: Scott Kostyshak <skostysh at lyx.org>
> Date:   Fri Dec 2 19:34:36 2022 -0500
> 
>     Comment
> ---
>  src/frontends/qt/GuiFontMetrics.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/frontends/qt/GuiFontMetrics.cpp b/src/frontends/qt/GuiFontMetrics.cpp
> index b00816d..e7dab1e 100644
> --- a/src/frontends/qt/GuiFontMetrics.cpp
> +++ b/src/frontends/qt/GuiFontMetrics.cpp
> @@ -257,7 +257,7 @@ int GuiFontMetrics::width(docstring const & s) const
>  		return *wid_p;
>  	PROFILE_CACHE_MISS(width);
>  	/* Several problems have to be taken into account:
> -	 * * QFontMetrics::width does not returns a wrong value with Qt5 with
> +	 * * QFontMetrics::width returns a wrong value with Qt5 with
>  	 *   some arabic text, since the glyph-shaping operations are not
>  	 *   done (documented in Qt5).
>  	 * * QTextLayout is broken for single characters with null width

JMarc, can you double check this fix was correct? I changed the literal
logic, and I just guessed at what was intended.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20221202/94c26318/attachment.asc>


More information about the lyx-devel mailing list