[patch] Selection stats in statusbar
Daniel
xracoonx at gmx.de
Wed Aug 17 13:52:19 UTC 2022
On 11/08/2022 08:54, Pavel Sanda wrote:
> On Wed, Aug 10, 2022 at 08:01:47AM +0200, Daniel wrote:
>> I just tested the new feature. Here are a couple of things that came to my
>> mind:
>>
>> 1. The delay timer seems not to be working as expected. Normally, i.e. in
>> other word processors, the idea is this:
>>
>> While typing, no updating takes place, only once the typing stops, the
>> update timer starts. Once typing is continued, the update timer is stopped.
>> I guess this is to make sure that calculation of the statistics is very
>> unlikely to interfere with the typing.
>
> This seems reasonable approach, actually better then the current one.
>
>> However, as it is now, the word count gets updated sometimes while
>> continuously typing. I thought that I had figured this out in my patch but
>> maybe not. (Or that is a part where you where wondering why it was as it
>> was.)
>
> Yes, your patch didn't make it clear in the comments how it works, and it was
> not straightforward from the code what is the combination if stops/starts
> supposed to do. This makes it hard to anyone from outside to fix if something
> breaks.
>
> If you are willing to improve it I am happy to push it into master.
I will re-check your patch now that it is in master and see whether I
can add the feature.
Yes, I agree that I did not comment my patch well. I wasn't sure whether
there would be interest, so it was only intended for people to try it
out. (I also wasn't sure from your earlier feedback whether you would
have liked more comments on my patch after I asked whether I should add
more comments.)
Daniel
More information about the lyx-devel
mailing list