Patch review

Pavel Sanda sanda at lyx.org
Wed Sep 29 12:25:28 UTC 2021


On Wed, Sep 29, 2021 at 01:01:42PM +0300, Yuriy Skalko wrote:
> >Older gcc will have problem:
> >
> >make[6]: Entering directory '/root/lyx/src/frontends/qt'
> >  CXX      ColorCache.o
> >  CXX      GuiBibtex.o
> >GuiBibtex.cpp: In member function 'void
> >lyx::frontend::GuiBibtex::setFileEncodings(const
> >std::__debug::vector<std::basic_string<wchar_t, std::char_traits<wchar_t>,
> >std::allocator<wchar_t> > >&)':
> >GuiBibtex.cpp:529:44: error: conversion from 'int' to 'Qt::MatchFlags {aka
> >QFlags<Qt::MatchFlag>}' is ambiguous
> >            Qt::MatchExactly | Qt::MatchWrap);
> > ...
> >
> >Pavel
> 
> Thanks for testing, Pavel. I've had a suspicion to this part with bit
> operators. I've removed it in the updated patch.

Looks good to me now. Pavel


More information about the lyx-devel mailing list