IconInfo iconInfo: member call on null pointer

[Kornel Benko]

Am Fri, 24 Sep 2021 23:20:51 -0400
schrieb Scott Kostyshak <skostysh at lyx.org>:

> After building with fsanitize=undefined -fno-omit-frame-pointer, I get the following:
> 
> $ cd lib/examples/ && lyx -e pdf Welcome.lyx
> /home/scott/lyxbuilds/master/repo/src/frontends/qt/GuiApplication.cpp:558:55: runtime
> error: member call on null pointer of type 'struct
> GuiApplication' /home/scott/lyxbuilds/master/repo/src/frontends/qt/GuiApplication.cpp:558:55:
> runtime error: member access within null pointer of type 'struct GuiApplication'
> 
> After that, LyX gives a backtrace and crashes. I attach the backtrace in case it's
> useful.
> 
> Just for informational purposes (I'm not proposing this as a patch), the following does
> fix the error:
> 
> diff --git a/src/frontends/qt/GuiApplication.cpp b/src/frontends/qt/GuiApplication.cpp
> index 01a646de37..b93c4753c7 100644
> --- a/src/frontends/qt/GuiApplication.cpp
> +++ b/src/frontends/qt/GuiApplication.cpp
> @@ -555,6 +555,8 @@ IconInfo iconInfo(FuncRequest const & f, bool unknown, bool rtl)
>         if (unknown)
>                 names << "unknown";
>  
> +       if (!theGuiApp())
> +           return res;
>         search_mode const mode = theGuiApp()->imageSearchMode();
>         // The folders where icons are searched for
>         QStringList imagedirs;
> 
> Scott

Why not? Looks perfect to me. But probably not the only place.

	Kornel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210925/461349d8/attachment.asc>