[LyX/master] Revert "Fix bug #10263"

[Scott Kostyshak]

On Tue, Apr 13, 2021 at 10:13:16AM +0200, Jean-Marc Lasgouttes wrote:
> commit 441c6a93590698c3c57982c8b80179d6809fb106
> Author: Jean-Marc Lasgouttes <lasgouttes at lyx.org>
> Date:   Mon Apr 12 20:44:58 2021 +0200
> 
>     Revert "Fix bug #10263"
>     
>     A series of commits, culminating at 812ff7de, pushed a few days later,
>     fixes the bug at its root. This one is not needed anymore to fix
>     
>     This reverts commit 001f5a47861f04c985323677dfd17ef15b8c33a7
> ---
>  src/insets/InsetFoot.h |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/src/insets/InsetFoot.h b/src/insets/InsetFoot.h
> index 1e4b0d2..0c3f65a 100644
> --- a/src/insets/InsetFoot.h
> +++ b/src/insets/InsetFoot.h
> @@ -45,10 +45,6 @@ private:
>  	///
>  	Inset * clone() const override { return new InsetFoot(*this); }
>  	///
> -	bool inheritFont() const override { return true; }
> -	///
> -	bool allowMultiPar() const override { return true; }
> -	///
>  	docstring custom_label_;
>  	///
>  	bool intitle_;
> -- 

The following ctest started failing with this commit:

  export/doc/ja/Tutorial_pdf5_systemF

The diff between the "bad" (current master) and "good" (current master
with this commit reverted) is as follows:

$ diff good.tex bad.tex 
61c61
< \author{\LyX プロジェクトチーム\thanks{なにかコメントや間違いの修正がある場合には，\protect\LyX 文書化メーリングリスト(\protect\href{mailto:lyx-docs at lists.lyx.org}{lyx-docs at lists.lyx.org})までお知らせ下さい．この文書の翻訳は，当初人見光太郎氏が行った貢献に基づいています．}}
---
> \author{\LyX プロジェクトチーム\thanks{{\normalsize なにかコメントや間違いの修正がある場合には，\protect\LyX 文書化メーリングリスト(\protect\href{mailto:lyx-docs at lists.lyx.org}{lyx-docs at lists.lyx.org})までお知らせ下さい．この文書の翻訳は，当初人見光太郎氏が行った貢献に基づいています．}}}
$ 

I have no idea why the {\normalsize ...} would cause the failure. Does
anyone know the problem?

Note that we are already aware of several other Japanese documents that
do not compile with non-TeX fonts:

  export/doc/ja/(Additional|LaTeXConfig|Math|UserGuide).*_systemF

so it would not be surprising if we need to add Tutorial.lyx to the list.

By the way, if this report does not lead to a fix in LyX or a bug
report, we should log this wasted time in
development/autotests/ctests-costs-benefits.txt.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210528/c5605158/attachment.asc>