[LyX/master] Revert "Fix bug #10263"

[Scott Kostyshak]

On Tue, Apr 13, 2021 at 10:13:16AM +0200, Jean-Marc Lasgouttes wrote:
> commit 441c6a93590698c3c57982c8b80179d6809fb106
> Author: Jean-Marc Lasgouttes <lasgouttes at lyx.org>
> Date:   Mon Apr 12 20:44:58 2021 +0200
> 
>     Revert "Fix bug #10263"
>     
>     A series of commits, culminating at 812ff7de, pushed a few days later,
>     fixes the bug at its root. This one is not needed anymore to fix
>     
>     This reverts commit 001f5a47861f04c985323677dfd17ef15b8c33a7
> ---
>  src/insets/InsetFoot.h |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/src/insets/InsetFoot.h b/src/insets/InsetFoot.h
> index 1e4b0d2..0c3f65a 100644
> --- a/src/insets/InsetFoot.h
> +++ b/src/insets/InsetFoot.h
> @@ -45,10 +45,6 @@ private:
>  	///
>  	Inset * clone() const override { return new InsetFoot(*this); }
>  	///
> -	bool inheritFont() const override { return true; }
> -	///
> -	bool allowMultiPar() const override { return true; }
> -	///
>  	docstring custom_label_;
>  	///
>  	bool intitle_;
> -- 

Starting with this commit a lot of docbook ctests started to fail. Thibaut, does the docbook code need to be adapted?

More information in case it is helpful:

With commit 441c6a93^:
99% tests passed, 1 tests failed out of 380
The following tests FAILED:
        3730 - export/examples/External_Material/Spreadsheet_docbook5 (Failed)


Starting with 441c6a93:
88% tests passed, 46 tests failed out of 380
The following tests FAILED:
        1648 - export/doc/Customization_docbook5 (Failed)
        1666 - export/doc/Development_docbook5 (Failed)
        1756 - export/doc/Intro_docbook5 (Failed)
        1851 - export/doc/Tutorial_docbook5 (Failed)
        1923 - export/doc/ca/Intro_docbook5 (Failed)
        1995 - export/doc/de/Customization_docbook5 (Failed)
        2085 - export/doc/de/Intro_docbook5 (Failed)
        2139 - export/doc/de/Tutorial_docbook5 (Failed)
        2175 - export/doc/el/Intro_docbook5 (Failed)
        2301 - export/doc/es/Intro_docbook5 (Failed)
        2355 - export/doc/es/Tutorial_docbook5 (Failed)
        2391 - export/doc/eu/Intro_docbook5 (Failed)
        2409 - export/doc/eu/Tutorial_docbook5 (Failed)
        2535 - export/doc/fr/Intro_docbook5 (Failed)
        2589 - export/doc/fr/Tutorial_docbook5 (Failed)
        2625 - export/doc/gl/Intro_docbook5 (Failed)
        2661 - export/doc/he/Intro_docbook5 (Failed)
        2679 - export/doc/he/Tutorial_docbook5 (Failed)
        2697 - export/doc/hu/Intro_docbook5 (Failed)
        2715 - export/doc/hu/Tutorial_docbook5 (Failed)
        2733 - export/doc/id/Intro_docbook5 (Failed)
        2751 - export/doc/id/Shortcuts_docbook5 (Failed)
        2769 - export/doc/id/Tutorial_docbook5 (Failed)
        2787 - export/doc/it/Intro_docbook5 (Failed)
        2805 - export/doc/it/Tutorial_docbook5 (Failed)
        2907 - export/doc/ja/Intro_docbook5 (Failed)
        2968 - export/doc/ja/Tutorial_docbook5 (Failed)
        2996 - export/doc/nb/Intro_docbook5 (Failed)
        3014 - export/doc/nb/Tutorial_docbook5 (Failed)
        3032 - export/doc/nl/Intro_docbook5 (Failed)
        3068 - export/doc/nl/Tutorial_docbook5 (Failed)
        3158 - export/doc/ro/Intro_docbook5 (Failed)
        3212 - export/doc/ru/Intro_docbook5 (Failed)
        3266 - export/doc/ru/Tutorial_docbook5 (Failed)
        3302 - export/doc/sk/Intro_docbook5 (Failed)
        3374 - export/doc/sv/Intro_docbook5 (Failed)
        3410 - export/doc/sv/Tutorial_docbook5 (Failed)
        3428 - export/doc/uk/Intro_docbook5 (Failed)
        3446 - export/doc/zh_CN/Intro_docbook5 (Failed)
        3461 - export/doc/zh_CN/Tutorial_docbook5 (Failed)
        3730 - export/examples/External_Material/Spreadsheet_docbook5 (Failed)
        4057 - export/examples/Modules/Noweb_docbook5 (Failed)
        4146 - export/examples/Modules/Rnw_%28knitr%29_docbook5 (Failed)
        5069 - export/examples/fr/Graphics_and_Insets/Feynman_Diagrams_docbook5 (Failed)
        5087 - export/examples/fr/Graphics_and_Insets/Itemize_Bullets_docbook5 (Failed)
        5141 - export/examples/fr/Modules/Braille_docbook5 (Failed)

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210522/f98f70ee/attachment.asc>