QProcess::startCommand deprecation

[Jürgen Spitzmüller]

Am Dienstag, dem 18.05.2021 um 11:02 +0200 schrieb Jean-Marc
Lasgouttes:
> I have been looking at backporting the following commit to stble (the
> last warning I see):
> 
> commit 9f92fc92bdd41c367b0975454a01c15403d51a60
> Author: Juergen Spitzmueller <spitz at lyx.org>
> Date:   Fri Mar 12 12:14:42 2021 +0100
> 
>      Yet another deprecation fix (this is the last one I am aware of)
> 
> 
> This uses QProcess::startDetached(cmd, args) instead of 
> QProcess::startDetached(cmd + args) for Qt >= 5.15.
> 
> I have a question though. I see that this new form already exists in
> Qt4
> https://doc.qt.io/archives/qt-4.8/qprocess.html
> 
> So, why use the conditionning on Qt 5.15 at all?
> 
> More generally, I am not sure that we are always conditionning on the
> right version. Example: in GuiAbout, Qt:endl is used for Qt>= 5.15, 
> whereas it has been introduced in 5.14 according to the docs.
> 
> I think that having the correct bounds will help us in the long term.

I think my rationale was to play safe and keep the deprecated function
until it was marked deprecated.

Jürgen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210518/5915398e/attachment.asc>