[LyX/master] Meet per-document spelling dictionaries (fixes #86 [sic!])

[Stephan Witt]

Am 08.03.2021 um 12:14 schrieb Pavel Sanda <sanda at lyx.org>:
> 
> On Mon, Mar 08, 2021 at 11:14:13AM +0100, Stephan Witt wrote:
>> Am 08.03.2021 um 07:27 schrieb Jürgen Spitzmüller <spitz at lyx.org>:
>>> 
>>> Am Sonntag, dem 07.03.2021 um 20:55 +0100 schrieb Stephan Witt:
>>>> To reproduce I
>>>> 
>>>> 1. Open the Help -> Intro.
>>>> 2. Boom.
>>> 
>>> Is it related to the darkmode runtime switch we recently added? You
>>> backtrace points towards that code region.
>>> 
>>> In any case, you can try bisecting.
>> 
>> I did it already. But I???m lost now. Bisect points to my commit 07122f066b.
>> I don???t see the reason and reversion of this is not easy. 
>> If I revert it manually it doesn???t help. The crash remains.
> 
> I struggle with the claim that bisect points to 07122f066b, yet if you revert
> it the crash remains. But that's essentially what bisect does.
> 
> Are you sure you did not errorneously flagged one of bisect steps wrongly?

My HEAD is ahead of origin by 4 commits (including the manual reversion - diff attached).

I assume e2f3dd5f6a2b73 is good and my HEAD is bad (2nd diff attached).

I’ll redo and log my steps here:

$ git bisect start HEAD e2f3dd5f6a2b736ed457c1b13361b2892aa54338
Bisecting: 29 revisions left to test after this (roughly 5 steps)
[31dc0acbb89b8b2b9a8783b02168c193ad41a98b] Layout fix

=> Compile error in AppleSpellChecker::check and EnchantChecker::check
=> fix it (add missing const & in front of docdict)

Compile and test with
1. Start LyX in Xcode
2. Open Intro (Einführung in german)
3. Spell check interactive
4. Cycle through complete document (more than 70 skips).

Ok, works.

$ git checkout src/AppleSpellChecker.cpp src/EnchantChecker.cpp
Updated 2 paths from the index
$ git bisect good
Bisecting: 14 revisions left to test after this (roughly 4 steps)
[b07084df2dbf04a7b54206ab5135b0f628bd59b8] Add ticks to zoom slider 

Compile and run. Test ok.

$ git bisect good
Bisecting: 7 revisions left to test after this (roughly 3 steps)
[07122f066b43f9dd41462932894a91aed78201d0] Refactoring: move check for match in spellignore() to buffer params.

Compile and run. Crash after 6 times „Überspringen“ (skip).

$ git bisect bad
Bisecting: 3 revisions left to test after this (roughly 2 steps)
[bc300585f7e5aaf412a843638b90b8c311b99e5a] Properly set initial zoom value

Compile and run. Test ok.

$ git bisect good
Bisecting: 1 revision left to test after this (roughly 1 step)
[be6dc7dd5dc10f79efaaaa2525b2ba77d0b02c46] Show zoom value in statusbar

Compile and run. Test ok.

$ git bisect good
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[430327152a23017797751e0b8e63552ccf84c466] Fix per-document dictionary with Mac

Compile and run. Test ok.

$ git bisect good
07122f066b43f9dd41462932894a91aed78201d0 is the first bad commit
commit 07122f066b43f9dd41462932894a91aed78201d0
Author: Stephan Witt <switt at lyx.org>
Date:   Sun Mar 7 17:46:01 2021 +0100

    Refactoring: move check for match in spellignore() to buffer params.

:040000 040000 9e429f821e1b40190ac577935ec368dc352fc748 24f5f679d4ccbc239bad0028b73c494bdfad8d83 M	src

Again the pointer to 07122f066b43f9dd41462932894a91aed78201d0.

I’m using Xcode with the cmake created project. I don’t recreate the project after a bisect step.

> It the crash 100% reproducible?

Yes.

Stephan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bisect-start-origin.diff
Type: application/octet-stream
Size: 8335 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210308/a948d3c1/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bisect-start-e2f3dd5f6a2b73.diff
Type: application/octet-stream
Size: 68362 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210308/a948d3c1/attachment-0003.obj>