[LyX/master] Meet per-document spelling dictionaries (fixes #86 [sic!])

[Stephan Witt]

Am 07.03.2021 um 14:36 schrieb Jürgen Spitzmüller <spitz at lyx.org>:
> 
> Am Sonntag, dem 07.03.2021 um 14:04 +0100 schrieb Stephan Witt:
>>> I can't follow you here. Sure it is.
>> 
>> IMO it is a new feature.
> 
> Where did I claim it isn't?
> 
> If you want to enhance it: be invited.

No I don’t want to enhance it *now*. We are in feature-freeze IMO.

>>>>> Also, as you say it is marked correctly after context menu
>>>>> action,
>>>>> there is probably only some call missing here.
>>>> 
>>>> Yes, probably.
>>> 
>>> I have just looked again at AppleSpellChecker and really do not see
>>> how
>>> this is so special. Maybe you just need to debug a bit
>>> Paragraph::spellCheck() (the routine which is in if (speller-
>>>> canCheckParagraph())). Well likely just a simple oversight. Check
>>>> for
>>> the return values of speller->check() gathered here. It should be
>>> LEARNED_WORD for the cases in question.
>> 
>> The difference is made by the canCheckParagraph() method of spellers.
> 
> Yes, I know (see my comment above).
> 
>> Paragraph::spellCheck() has different code paths for it.
>> 
>> With paragraph check enabled - see AppleSpellChecker.h - the speller
>> sees the whole sentence as a word and marks one or more words as mis-
>> spelled at once.
> 
> I see. Can you try (and maybe play with) the attached patch?

This is better now.

Next problem: I cannot remove the learned word from document dictionary?
Should this work?

Stephan