[LyX/master] Meet per-document spelling dictionaries (fixes #86 [sic!])

[Jürgen Spitzmüller]

Am Sonntag, dem 07.03.2021 um 13:45 +0100 schrieb Stephan Witt:
> I see more than one problem.
> 
> 1. The spell checker on Mac is an OS service and there is support for
> document scope too. Probably this collides with our implementation in
> LyX.

Why is this a problem? The implementation I have done is OS-independent
and should work on the Mac, too. AppleSpellChecker really does not
strike me too different from the other spellers.

> 2. Document local dictionary is only one option to improve the
> situation.
> Imagine documents for specific context - e.g. medical or chemical
> science -
> there it would be better to associate the document with a dedicated
> personal
> dictionary and/or even share it with colleagues.

How does this relate to the problem we are just talking about? The
feature request I addressed was about document local dictionaries,
nothing else.

> 3. IMO this wasn’t a bug fix - it’s an enhancement or a new feature.

I can't follow you here. Sure it is.

> > Also, as you say it is marked correctly after context menu action,
> > there is probably only some call missing here.
> 
> Yes, probably.

I have just looked again at AppleSpellChecker and really do not see how
this is so special. Maybe you just need to debug a bit
Paragraph::spellCheck() (the routine which is in if (speller-
>canCheckParagraph())). Well likely just a simple oversight. Check for
the return values of speller->check() gathered here. It should be
LEARNED_WORD for the cases in question.

Best,
Jürgen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210307/c016d8fd/attachment-0001.asc>