[LyX/master] Revert "Fix bug #10263"

[Jean-Pierre Chrétien]

Le 13/06/2021 à 18:33, Kornel Benko a écrit :
> Am Sun, 13 Jun 2021 11:42:59 -0400
> schrieb Scott Kostyshak <skostysh at lyx.org>:
> 
>> On Sat, May 29, 2021 at 01:47:41PM -0400, Scott Kostyshak wrote:
>>> On Fri, May 28, 2021 at 10:48:51AM -0400, Scott Kostyshak wrote:
>>>> On Tue, Apr 13, 2021 at 10:13:16AM +0200, Jean-Marc Lasgouttes wrote:
>>>>> commit 441c6a93590698c3c57982c8b80179d6809fb106
>>>>> Author: Jean-Marc Lasgouttes <lasgouttes at lyx.org>
>>>>> Date:   Mon Apr 12 20:44:58 2021 +0200
>>>>>
>>>>>      Revert "Fix bug #10263"
>>>>>      
>>>>>      A series of commits, culminating at 812ff7de, pushed a few days later,
>>>>>      fixes the bug at its root. This one is not needed anymore to fix
>>>>>      
>>>>>      This reverts commit 001f5a47861f04c985323677dfd17ef15b8c33a7
>>>>> ---
>>>>>   src/insets/InsetFoot.h |    4 ----
>>>>>   1 files changed, 0 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/src/insets/InsetFoot.h b/src/insets/InsetFoot.h
>>>>> index 1e4b0d2..0c3f65a 100644
>>>>> --- a/src/insets/InsetFoot.h
>>>>> +++ b/src/insets/InsetFoot.h
>>>>> @@ -45,10 +45,6 @@ private:
>>>>>   	///
>>>>>   	Inset * clone() const override { return new InsetFoot(*this); }
>>>>>   	///
>>>>> -	bool inheritFont() const override { return true; }
>>>>> -	///
>>>>> -	bool allowMultiPar() const override { return true; }
>>>>> -	///
>>>>>   	docstring custom_label_;
>>>>>   	///
>>>>>   	bool intitle_;
>>>>> --
>>>>
>>>> The following ctest started failing with this commit:
>>>>
>>>>    export/doc/ja/Tutorial_pdf5_systemF
>>>>
>>>> The diff between the "bad" (current master) and "good" (current master
>>>> with this commit reverted) is as follows:
>>>>
>>>> $ diff good.tex bad.tex
>>>> 61c61
>>>> < \author{\LyX
>>>> プロジェクトチーム\thanks{なにかコメントや間違いの修正がある場合には，\protect\LyX
>>>> 文書化メーリングリスト(\protect\href{mailto:lyx-docs at lists.lyx.org}{lyx-docs at lists.lyx.org})までお知らせ下さい．この文書の翻訳は，当初人見光太郎氏が行った貢献に基づいています．}}
>>>> ---
>>>>> \author{\LyX プロジェクトチーム\thanks{{\normalsize
>>>>> なにかコメントや間違いの修正がある場合には，\protect\LyX
>>>>> 文書化メーリングリスト(\protect\href{mailto:lyx-docs at lists.lyx.org}{lyx-docs at lists.lyx.org})までお知らせ下さい．この文書の翻訳は，当初人見光太郎氏が行った貢献に基づいています．}}}
>>>> $
>>>>
>>>> I have no idea why the {\normalsize ...} would cause the failure. Does
>>>> anyone know the problem?
>>>>
>>>> Note that we are already aware of several other Japanese documents that
>>>> do not compile with non-TeX fonts:
>>>>
>>>>    export/doc/ja/(Additional|LaTeXConfig|Math|UserGuide).*_systemF
>>>>
>>>> so it would not be surprising if we need to add Tutorial.lyx to the list.
>>>>
>>>> By the way, if this report does not lead to a fix in LyX or a bug
>>>> report, we should log this wasted time in
>>>> development/autotests/ctests-costs-benefits.txt.
>>>
>>> I think the French Powerdot example might also have a footnote where
>>> this commit changes behavior. If I remove the footnote, compilation
>>> succeeds. I did not do a bisect on that document but it feels like a
>>> similar issue.
>>
>> Does anyone know what the core issue is? Here is the LaTeX code causing
>> the problem after this commit:
>>
>> \thanks{{\normalsize Traduction française Jean-Pierre
>> Chrétien, }{\normalsize\texttt{}<jeanpierre.chretien at free.fr>}}{\normalsize}, novembre
>> 2009.}}}
>>
>> Do we need to adapt lyx2lyx perhaps? Or is this a LyX LaTeX export
>> issue?
>>
>> Scott
> 
> This compiles also if changing the font inside the footnote (Teletype->default)

Hello

The French Powerdot file was a mess because the Footnote which gives info about 
the translator exported to LaTeX as \thanks, splitting the content in two pieces 
and leaving spurious parentheses at the end.

I dissolved the Footnote inset and made the content a LyX note, compiles fine now.

Committed at 5b0b3f053e

-- 
Jean-Pierre