[PATCH] Patches to review
Richard Kimberly Heck
rikiheck at lyx.org
Thu Jan 21 23:18:01 UTC 2021
On 1/21/21 10:10 AM, Pavel Sanda wrote:
> On Thu, Jan 21, 2021 at 09:51:46AM -0500, Scott Kostyshak wrote:
>> On Thu, Jan 21, 2021 at 09:38:08AM +0200, Yuriy Skalko wrote:
>>> Please review my recent patches for LyX.
>> Patch 1 (the Development.lyx patch) is good. Nice addition of the enum class.
>> Patch 4 also looks good. I thought it could break Qt 4.8 compilation but that's not the case [1, 2].
>> Sorry that I don't know enough to look at the others.
> 2,3 is fine. 5 is fine unless we use direct  access somewhere.
> I know Riki did not announce it officially yet, but we should start looking at fixing bugs which hinder us from 2.4 release rather than refactoring the codebase. I know, boring...
I think I did send an email to that effect. In any event, my
understanding is that Yuriy intends to commit these things to a feature
branch for now. We don't want to risk another weird surprise like with
the move constructor.
More information about the lyx-devel