[PATCH] Patches to review

Scott Kostyshak skostysh at lyx.org
Thu Jan 21 14:51:46 UTC 2021

On Thu, Jan 21, 2021 at 09:38:08AM +0200, Yuriy Skalko wrote:
> Please review my recent patches for LyX.

Patch 1 (the Development.lyx patch) is good. Nice addition of the enum class.

Patch 4 also looks good. I thought it could break Qt 4.8 compilation but that's not the case [1, 2].

Sorry that I don't know enough to look at the others.


[1] https://doc.qt.io/archives/qt-4.8/qt.html#MouseButton-enum
[2] https://code.qt.io/cgit/qt/qtlocation.git/commit/?id=f3a34ce8890c68c04212eafa0ae2c9eeeb60b555

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210121/0be5f8ab/attachment.asc>

More information about the lyx-devel mailing list