[LyX/master] Add move constructor and move assignment operator for FileName class

Kornel Benko kornel at lyx.org
Thu Jan 14 16:25:01 UTC 2021


Am Wed, 13 Jan 2021 11:59:28 -0500
schrieb Scott Kostyshak <skostysh at lyx.org>:

> On Wed, Jan 13, 2021 at 10:37:30AM +0100, Jean-Marc Lasgouttes wrote:
> > Le 13/01/2021 à 10:21, Yuriy Skalko a écrit :  
> > > > Hi Yuriy,
> > > > 
> > > > I’m seeing a crash after this commit when using File->Open recent.
> > > > 
> > > > 
> > > > I’m having 5 files in list and the first entry has nullptr as
> > > > private data.  
> > > 
> > > Hi Stephan,
> > > Sorry for late answer. Does it crash always on choosing the first file
> > > in Recent list? I cannot reproduce this on Windows and Linux (using GCC
> > > in both cases) and suspect it is Clang-only issue.
> > > 
> > > As I understand Scott used Clang on Linux. Is this crash reproducible
> > > there?  
> > 
> > Note that it may depend on the library (libc++) rather than the compiler.  
> 
> I just tested with Clang and cannot reproduce. Stephan, does the list need to have more
> than one "recent file"? Note that the recent files are stored in the "session" file.
> You could experiment by seeing if it depends on which file you choose or how many
> entries are in the menu.
> 
> Scott

I cannot even compile everything under clang8
/usr2/src/lyx/lyx-git/src/support/FileMonitor.cpp:62:9: error: call to 'make_unique' is
ambiguous return make_unique<FileMonitor>(instance().getGuard(filename));
               ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/unique_ptr.h:834:5:
note: candidate function [with _Tp = lyx::support::FileMonitor, _Args =
<std::shared_ptr<lyx::support::FileMonitorGuard>>] make_unique(_Args&&... __args)

	Kornel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210114/ab824889/attachment-0001.asc>


More information about the lyx-devel mailing list