[LyX/master] Fix bug #10635
Richard Kimberly Heck
rikiheck at lyx.org
Thu Jan 14 02:50:25 UTC 2021
On 1/13/21 6:29 PM, Kornel Benko wrote:
> Am Thu, 14 Jan 2021 00:00:17 +0100
> schrieb Kornel Benko <kornel at lyx.org>:
>> Am Wed, 13 Jan 2021 20:38:07 +0100 (CET)
>> schrieb Richard Kimberly Heck <rikiheck at lyx.org>:
>>> commit d41ec3368de969a20a16e3812bd388b4ed7beafb
>>> Author: Richard Kimberly Heck <rikiheck at lyx.org>
>>> Date: Wed Jan 13 14:38:48 2021 -0500
>>> Fix bug #10635
>>> src/frontends/qt/GuiView.cpp | 2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>> diff --git a/src/frontends/qt/GuiView.cpp b/src/frontends/qt/GuiView.cpp
>>> index 714af17..07e08e0 100644
>>> --- a/src/frontends/qt/GuiView.cpp
>>> +++ b/src/frontends/qt/GuiView.cpp
>>> @@ -4162,6 +4162,8 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult &
>>> dr) insertLyXFile(from_utf8(cmd.getArg(0)), true);
>>> + dr.forceBufferUpdate();
>>> + dr.screenUpdate(Update::Force);
>> Probably? this or one of the latest commits causes crashes ATM.
>> I get the attached. The workarea is the regex-field,
>> I was trying to modify the regex-content after a cancelled search
> Sorry, this commit was not the reason, the crash occurred before. I will try to bisect
No problem. Good luck!
PS I would be VERY worried if this kind of commit caused a problem.
Flagging the updates we need to do through DispatchResult is supposed to
prevent problems caused by doing such things mid-dispatch.
More information about the lyx-devel