Renaming math stream objects

Richard Kimberly Heck rikiheck at lyx.org
Sat Jan 2 16:54:08 UTC 2021


On 1/2/21 11:33 AM, Thibaut Cuvelier wrote:
> I'm just upping this conversation: can I push the patches to rename
> the classes to MathMLStream and TeXMathStream?

Yes, I think that's fine.

Riki


>
> On Mon, 28 Dec 2020 at 20:18, Thibaut Cuvelier <tcuvelier at lyx.org
> <mailto:tcuvelier at lyx.org>> wrote:
>
>     On Mon, 28 Dec 2020 at 19:33, Jean-Marc Lasgouttes
>     <lasgouttes at lyx.org <mailto:lasgouttes at lyx.org>> wrote:
>
>         Le 26 décembre 2020 20:07:19 GMT+01:00, Thibaut Cuvelier
>         <tcuvelier at lyx.org <mailto:tcuvelier at lyx.org>> a écrit :
>
>             Dear list,
>
>             In https://www.lyx.org/trac/ticket/12055
>             <https://www.lyx.org/trac/ticket/12055>, there was some
>             confusion about the name of the streams used to output
>             math: there is OctaveStream for Octave, MathematicaStream
>             for Mathematica, etc., but MathStream for MathML (the name
>             is much more generic than what the class does) and
>             WriteStream for standard LaTeX math (the name is unrelated
>             to the features of the class).
>
>             As proposed in the ticket, I attach two patches to rename
>             these classes so that their name is much more descriptive.
>             Is it OK to push these commits?
>
>             Thibaut
>
>
>         What you propose makes sense, but LaTeXMathStream is a bit
>         long. What about using just MathStream? Or TeXMathStream like
>         we have otexstream.
>
>
>     The problem with MathStream is that, currently, the MathML stream
>     is called MathStream, it would be best to avoid reusing that name
>     for something very similar that soon.
>     I also wanted to avoid (La)TeXStream, because that could be
>     mistaken with the generation of the TeX file, while it's
>     restricted to maths.
>
>     I like TeXMathStream, though.
>      
>
>         Also, I am not sure why math streams use different
>         capitalization rules than their text counterpart.
>
>
>     What do you mean with "text counterpart"? Things like
>     MathematicaStream or MaximaStream just rely on odocstream
>     (odocstringstream for HTMLStream and the one for MathML), there is
>     no real counterpart for these streams.
>
>     Otherwise, it's quite common in the whole code base to have
>     capitalised names (camel case) for classes, it's more like
>     odocstream & co. follow a different convention (closer to the STL,
>     but I guess that's because they just act like stringstream).
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20210102/bc8d6751/attachment-0001.html>


More information about the lyx-devel mailing list