[LyX/master] Paragraph::needsCProtection(): use inset list

Scott Kostyshak skostysh at lyx.org
Fri Dec 24 02:39:00 UTC 2021


On Fri, Dec 24, 2021 at 12:57:20AM +0100, Thibaut Cuvelier wrote:
> On Fri, 24 Dec 2021 at 00:50, Thibaut Cuvelier <tcuvelier at lyx.org> wrote:
> 
> > On Thu, 23 Dec 2021 at 22:26, Scott Kostyshak <skostysh at lyx.org> wrote:
> >
> >> On Thu, Dec 23, 2021 at 03:07:00PM -0500, Scott Kostyshak wrote:
> >> > On Thu, Dec 23, 2021 at 11:36:53AM +0100, Kornel Benko wrote:
> >> > > Am Wed, 22 Dec 2021 22:05:02 -0500
> >> > > schrieb Scott Kostyshak <skostysh at lyx.org>:
> >> > >
> >> > > > On Wed, Dec 22, 2021 at 05:16:45PM +0100, Jean-Marc Lasgouttes
> >> wrote:
> >> > > > > Le 22/12/2021 à 16:52, Scott Kostyshak a écrit :
> >> > > > > > On Wed, Dec 22, 2021 at 04:16:30PM +0100, Jean-Marc Lasgouttes
> >> wrote:
> >> > > > > >
> >> > > > > > > Do we have a cprotect torture test, BTW?
> >> > > > > >
> >> > > > > > We don't. But I could spend some time setting these up. Just to
> >> make
> >> > > > > > sure, you mean examples of .lyx files that need the cprotect
> >> feature to
> >> > > > > > compile without error, right?
> >> > > > >
> >> > > > > Yes, that would be nice.
> >> > > >
> >> > > > I added a test at 87bea678. I'll add more files to that directory
> >> > > > (autotests/export/latex/lyxbugs-resolved/cprotect) as I find them.
> >> > > >
> >> > > > Scott
> >> > >
> >> > > From the tests there, only
> >> > >
> >> export/export/latex/lyxbugs-resolved/cprotect/9313-comment-in-figure-float-caption_docbook5
> >> > > fails.
> >> >
> >> > Indeed, thanks for catching that, Kornel. Thibaut, is this an easy fix
> >> > or should we invert?
> >>
> >> Thibaut, please also check 7779-float-in-par-env.lyx.
> >>
> >
> > DocBook-wise, 9313 is truly a bug (the export code thinks there is a
> > title, but as there's just a comment and no actual title it all breaks).
> > 7779 is really strange, I'll have to take a deeper look to see what's going
> > on.
> >
> 
> For 7779, there is no hope, as a figure within a title does not make sense
> at all, so it cannot be valid DocBook under any circumstances. This one
> should be inverted.

Thanks for taking a look. Inverted at 9d64a2f2.

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20211223/e9764665/attachment.asc>


More information about the lyx-devel mailing list