Footnote size is larger on master (\normalsize is prepended)

Wed Dec 8 18:17:03 UTC 2021

Le 03/12/2021 à 17:00, Scott Kostyshak a écrit :
> On Fri, Dec 03, 2021 at 12:46:13PM +0100, Jean-Marc Lasgouttes wrote:
>> Le 31/10/2021 ï¿½ 18:11, Scott Kostyshak a ï¿½critï¿½:
>>> See the attached file. On master, \normalsize is included inside the footnote, which is different from 2.3.x.
>>
>> Here is my take on how to properly fix this issue. I do not know however
>> what it does in other situations. Scott, do you have magic scripts and tests
>> to see the effect of this?
> 
> No magic scripts. All I do is manually compile the 2.3.0 user documents
> with 2.3.0 (or 2.3.x) and with master and then run 'diffpdf' on the
> results. I'm not sure it makes sense to test that the LaTeX is
> equivalent since often there are differences in LyX's LaTeX output that
> are expected that do not cause a difference in the PDF output. We could
> imagine some automated tests with e.g. 'comparepdf' (a commandline tool)
> that I think could check whether the PDF output are the same. We'd have
> to disable the date showing up.

OK, I have done the main manuals, and found in UserGuide a place where a 
greyedout note was inserted in bold context. This shows that a 
\normalfont was missing in the lyxgreyedout definition, and the updated 
patch adds that.

What else could I try to be convinced that it works? Do we have font 
torture tests?

JMarc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Tentative-patch-fix-font-inside-footnote-inset.patch
Type: text/x-patch
Size: 4755 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20211208/85ed7a73/attachment-0001.bin>