Footnote size is larger on master (\normalsize is prepended)

[Scott Kostyshak]

On Fri, Dec 03, 2021 at 12:46:13PM +0100, Jean-Marc Lasgouttes wrote:
> Le 31/10/2021 � 18:11, Scott Kostyshak a �crit�:
> > See the attached file. On master, \normalsize is included inside the footnote, which is different from 2.3.x.
> 
> Here is my take on how to properly fix this issue. I do not know however
> what it does in other situations. Scott, do you have magic scripts and tests
> to see the effect of this?

No magic scripts. All I do is manually compile the 2.3.0 user documents
with 2.3.0 (or 2.3.x) and with master and then run 'diffpdf' on the
results. I'm not sure it makes sense to test that the LaTeX is
equivalent since often there are differences in LyX's LaTeX output that
are expected that do not cause a difference in the PDF output. We could
imagine some automated tests with e.g. 'comparepdf' (a commandline tool)
that I think could check whether the PDF output are the same. We'd have
to disable the date showing up.

Scott

> 
> My belief is that this is the correct way of doing things. Some other parts
> of the code may conflict with that, though.
> 
> I added in the commit message some notes gathered during my research, so
> that they do not get lost.
> 
> JMarc
> 
> -- 
> lyx-devel mailing list
> lyx-devel at lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20211203/6be8d848/attachment.asc>