Complex document compiles with 2.3.x but not with master

[Scott Kostyshak]

On Thu, Sep 17, 2020 at 08:43:43AM +0200, Jürgen Spitzmüller wrote:
> Am Dienstag, den 15.09.2020, 22:53 -0400 schrieb Scott Kostyshak:
> > Attached is an example file. It seems that lyx2lyx needs to add
> > "\textheight" (or whichever is selected) when moving the "height"
> > parameter to the custom LaTeX? 
> 
> Fixed.

Thanks for the quick fix. I checked that the small example file compiles
now as well as the original file.

> > Another difference I see and don't understand is that the 2.3.x file
> > outputs "keepaspectratio" even though the box is not checked.
> 
> I don't see this.

I don't see this anymore either. I think I made a mistake.

There is another issue that is related. Before your fix, when I exported
the small example document to LyX 2.3.x, I got a lyx2lyx error. I no
longer get that error with the small example document, but I do with the
complex document. The following reproduces the error (if "lyx" is your
master binary):

git clone 'https://github.com/ahmed-rashed/ThesisTemplate' && cd ThesisTemplate && lyx -e lyx23x Thesis.lyx

Here is the error I get:

Warning: An error ocurred in 588, <function revert_totalheight at 0x7f3044a5ddd0>
Traceback (most recent call last):
  File "/home/scott/lyxbuilds/master/repo/lib/lyx2lyx/lyx2lyx", line 97, in <module>
    main()
  File "/home/scott/lyxbuilds/master/repo/lib/lyx2lyx/lyx2lyx", line 91, in main
    doc.convert()
  File "/home/scott/lyxbuilds/master/repo/lib/lyx2lyx/LyX.py", line 702, in convert
    conv(self)
  File "/home/scott/lyxbuilds/master/repo/lib/lyx2lyx/lyx_2_4.py", line 3515, in revert_totalheight
    if oldval[1] == ".":
IndexError: string index out of range
support/Systemcall.cpp (291): Systemcall: 'python3 -tt "/home/scott/lyxbuilds/master/repo/lib/lyx2lyx/lyx2lyx" -V 2.3 -o "Thesis.23.lyx" "Thesis.lyx"' finished with exit code 1
Error: Cannot convert file
----------------------------------------
An error occurred while running:
python -tt $$s/lyx2lyx/lyx2lyx -V 2.3 -o "Thesis.23.lyx" "Thesis.lyx"

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200917/2802bcae/attachment.asc>