Fwd: Re: [PATCH] Fix uninitialized variable with wrong type
Jean-Marc Lasgouttes
lasgouttes at lyx.org
Fri Sep 11 13:59:48 UTC 2020
Le 11/09/2020 à 12:30, Yuriy Skalko a écrit :
>> I like the patch. Did you manage to test it ? I do not know how to check that errors are caught.
>
> Thanks. I tested it in my normal LyX usage on Windows. How to provide
> more thorough testing?
>
>
>> The following code
>> + bool valid = (pret == 0);
>> + if (!success)
>> + valid = false;
>> should be replaced with
>> + bool valid = (pret == 0) && valid;
>>
>> I would also prefer to have the definition of the struct in multi-line format.
>
> You've meant "&& success", right? I've done the corrections.
Right, this is what I meant.
JMarc
More information about the lyx-devel
mailing list