Fwd: Re: [PATCH] Fix uninitialized variable with wrong type

Richard Kimberly Heck rikiheck at lyx.org
Fri Sep 11 13:44:51 UTC 2020


On 9/11/20 4:22 AM, Jean-Marc Lasgouttes wrote:
> Hello,
>
> I get back to the list to continue the discussion.
>
> I like the patch. Did you manage to test it ? I do not know how to
> check that errors are caught.
>
> The following code
> +    bool valid = (pret == 0);
> +    if (!success)
> +        valid = false;
> should be replaced with
> +    bool valid = (pret == 0) && valid;

Which could then be const, I suspect.

Riki




More information about the lyx-devel mailing list