[PATCH] Fix uninitialized variable with wrong type

Kornel Benko kornel at lyx.org
Wed Sep 9 20:14:40 UTC 2020


Am Wed, 9 Sep 2020 22:42:59 +0300
schrieb Yuriy Skalko <yuriy.skalko at gmail.com>:

> > I meant,
> > if what you done is correct, then also the call in ForkedCalls.cpp should be 
> > corrected.
> > 
> > Both places refer to WIN32 anyway.
> > 
> >         Kornel  
> 
> 
> Since pclose (Unix) returns signed int and GetExitCodeProcess (Windows)
> returns unsigned DWORD, and then result is compared with -1 in common
> branch, now I don't see clean way to get rid of the warning in this mix
> of conditional compilation branches. Let's leave as it is now.
> 
> There is similar mix of signed/unsigned in ForkedCalls.cpp (setRetValue
> call) but without compiler warnings.
> 
> 
> Yuriy
> 

What about this?

	Kornel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: filetools.cpp.patch
Type: text/x-patch
Size: 643 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200909/18659ea3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20200909/18659ea3/attachment.asc>


More information about the lyx-devel mailing list