[LyX/master] #11756 cleanup the view menu on Mac

Stephan Witt st.witt at gmx.net
Thu Sep 3 20:05:20 UTC 2020


Am 31.08.2020 um 17:45 schrieb Stephan Witt <st.witt at gmx.net>:
> 
> Am 31.08.2020 um 17:25 schrieb Jean-Marc Lasgouttes <lasgouttes at lyx.org>:
>> 
>> Le 30/08/2020 à 22:29, Stephan Witt a écrit :
>>> Am 30.08.2020 um 16:56 schrieb Pavel Sanda <sanda at lyx.org>:
>>>> 
>>>> On Sun, Aug 30, 2020 at 03:58:34PM +0200, Stephan Witt wrote:
>>>>> 1. Tab Bar related - I don???t know how. Probably not w/o Qt-support for it.
>>>> 
>>>> showBar like in GuiWorkArea.cpp:1714 does not work?
>>>> It could be easily added as a part of ui-toggle lfun.
>>> Ok, I looked it up.
>> 
>> Thanks for doing that.
>>> I understand it this way:
>>> 1. We should opt-out the menu item (as I did with my change).
>>> 2. We should check for the value of NSWindowUserTabbingPreference on reading lyxrc and use it if there is no value defined.
>>> Something like the attached patch will do (2).
>> 
>> The patch looks good. What happens on older versions of macOS. Do they all implement that?
> 
> It was a shot in the dark. It works surprisingly well on Catalina and Mojave. I’ll check it for 10.11.6 (El Capitan) next.
> In principle it should be handled by the test respondsToSelector…

I tested it with Qt 5.9.9 … it starts w/o problems on 10.11.6.

Stephan


More information about the lyx-devel mailing list