--std=c++11 fails on master

Richard Kimberly Heck rikiheck at lyx.org
Tue Oct 27 06:49:18 UTC 2020


On 10/26/20 10:49 PM, Scott Kostyshak wrote:
> On Mon, Oct 26, 2020 at 09:32:33AM +0200, Yuriy Skalko wrote:
>>> I have the following:
>>>
>>> #define HAVE_DEF_MAKE_UNIQUE 1
>>>
>>> Here is the diff I am using to force C++11:
>>>
>>> diff --git a/development/cmake/modules/FindCXX11Compiler.cmake
>>> b/development/cmake/modules/FindCXX11Compiler.cmake
>>> index f9a1aaf045..b990191424 100644
>>> --- a/development/cmake/modules/FindCXX11Compiler.cmake
>>> +++ b/development/cmake/modules/FindCXX11Compiler.cmake
>>> @@ -57,8 +57,6 @@ else()
>>>  # Detection of c++20 works well, but our code is not ready for it yet.
>>>  # We currently get errors with internal boost and also from our code.
>>>  #        "--std=c++20"
>>> -        "--std=c++17"
>>> -        "--std=c++14"
>>>          "--std=c++11"
>>>          "--std=gnu++11"
>>>          "--std=gnu++0x"
>>>
>>> Scott
>> So that's why it gives compilation error. As I said before
>> HAVE_DEF_MAKE_UNIQUE should be inactive in C++11 mode. Have you tried to
>> remove CMake cache as Kornel suggested?
> I did not try to remove the CMake cache, but Kornel sent me a patch that
> seems to work.

Is this a patch we need in master?

Riki




More information about the lyx-devel mailing list