missing #includes complaints by MSVC 2017

[Panruo Wu]

Dear LyX developers,

I just tried to compile LyX (commit
2c1753a5265c59ebd11fc465cdb119ff589ad965) on windows 10 with MSVC 2017
toolkit, and encountered compiling errors of the sort:

   src\DocIterator.h(335): error C2039: 'min': is not a member of 'std

and another one about std::isspace.

It's easy to fix by including the missing include files. After the
following patch it compiles fine:
===============================
$ git diff
diff --git a/src/DocIterator.h b/src/DocIterator.h
index a3786c4401..69930fcc7d 100644
--- a/src/DocIterator.h
+++ b/src/DocIterator.h
@@ -15,6 +15,7 @@
 #include "CursorSlice.h"

 #include <vector>
+#include <algorithm>

 namespace lyx {

diff --git a/src/insets/InsetBibtex.cpp b/src/insets/InsetBibtex.cpp
index bee485eeb6..4c131942ee 100644
--- a/src/insets/InsetBibtex.cpp
+++ b/src/insets/InsetBibtex.cpp
@@ -55,6 +55,7 @@
 #include <utility>

 #include <iostream>
+#include <cctype>

 using namespace std;
 using namespace lyx::support;
diff --git a/src/xml.cpp b/src/xml.cpp
index e50e55972b..b785d0776b 100644
--- a/src/xml.cpp
+++ b/src/xml.cpp
@@ -33,6 +33,7 @@
 #include <map>
 #include <functional>
 #include <QThreadStorage>
+#include <cctype>

 using namespace std;
 using namespace lyx::support;

=======================

Cheers,
--Panruo Wu

ReplyForward