[LyX/master] Cmake build: Next try to use of '--std=c++17' for gnu compiler"

[Scott Kostyshak]

On Thu, Oct 22, 2020 at 06:54:59PM +0200, Kornel Benko wrote:
> Am Thu, 22 Oct 2020 12:07:17 -0400
> schrieb Scott Kostyshak <skostysh at lyx.org>:
> 
> > On Thu, Oct 22, 2020 at 05:42:33PM +0200, Kornel Benko wrote:
> > > Am Thu, 22 Oct 2020 10:20:49 -0400
> > > schrieb Scott Kostyshak <skostysh at lyx.org>:
> > >   
> > > > On Thu, Oct 22, 2020 at 01:23:51PM +0200, Kornel Benko wrote:  
> > > > > commit d954a6b09cc9d284a34510f076c16f22b425ead2
> > > > > Author: Kornel Benko <kornel at lyx.org>
> > > > > Date:   Thu Oct 22 13:46:29 2020 +0200
> > > > > 
> > > > >     Cmake build: Next try to use of '--std=c++17' for gnu compiler"
> > > > >     
> > > > >     Setting CMAKE_CXX_STANDARD explicitly, so that cmake can use
> > > > >     correct cxx-flags
> > > > > ---    
> > > > 
> > > > I get errors (although now at least it says '17' instead of '20' so that's
> > > > progress):
> > > > 
> > > >   CMake Error at src/CMakeLists.txt:113 (add_executable):
> > > >     CXX_STANDARD is set to invalid value '17'
> > > >   
> > > >   
> > > >   CMake Error at src/frontends/CMakeLists.txt:18 (add_library):
> > > >     CXX_STANDARD is set to invalid value '17'
> > > >   
> > > >   
> > > >   CMake Error at src/frontends/qt/CMakeLists.txt:42 (add_library):
> > > >     CXX_STANDARD is set to invalid value '17'
> > > >   
> > > >   
> > > >   CMake Error at src/frontends/tests/CMakeLists.txt:10 (add_executable):
> > > >     CXX_STANDARD is set to invalid value '17':
> > > > 
> > > > g++ --version
> > > > g++ (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609
> > > > 
> > > > I don't use this system much so if that GCC version is too old, then I'm
> > > > fine if we do not support it. But if we dream that someday Pavel will
> > > > switch to CMake, we should be ready :)
> > > > 
> > > > Scott  
> > > 
> > > This is cmake message only. What is your cmake version?
> > > Apparently '17' is enabled with version 3.8, and '20' with version 3.12  
> > 
> > cmake version 3.5.1
> > 
> > Scott
> 
> OK, will ask cmake for available features :(

I'm not sure if you wanted me to retest after your latest commit, but I now get the following:

-- TOP_SRC_DIR = /home/scott/lyxbuilds/master/repo
--
-- Building out-of-source
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Selecting build type defaults from configure.ac
--
-- CXX11_FLAG_DETECTED = "--std=c++17"
-- Compiler supports std_regex
-- Found CXX11Compiler: --std=c++17
-- Using GCC version 5.4.0
-- CMAKE_COMPILER_IS_GNUCXX = 1
CMake Error at CMakeLists.txt:702 (if):
  if given arguments:

    "stdfeature" "GREATER_EQUAL" "0"

  Unknown arguments specified


-- Configuring incomplete, errors occurred!
See also "/home/scott/lyxbuilds/master/CMakeBuild/CMakeFiles/CMakeOutput.log".

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201022/cdc238fa/attachment-0001.asc>