Refactoring patches

Yuriy Skalko yuriy.skalko at gmail.com
Tue Oct 20 08:39:41 UTC 2020


> Assuming it compiles, it looks fine. Using strfwd.h in various places is definitely worth it.
> 
> Riki

Thanks, committed.


> I guess you checked, but these two below look strange...
> Otherwise looks fine. P
> 
> 
>> diff --git a/src/Buffer.h b/src/Buffer.h
>> index 2d96ff938e..7d1b5eca97 100644
>> --- a/src/Buffer.h
>> +++ b/src/Buffer.h
>> @@ -13,6 +13,7 @@
>>  #define BUFFER_H
>>  
>>  #include "OutputEnums.h"
>> +#include "ParIterator.h"
>>  
>>  #include "support/unique_ptr.h"
>>  #include "support/strfwd.h"
> 
> Look suspicious.

> 
>> diff --git a/src/Text.h b/src/Text.h
>> index 3faccb8c59..412e6f036c 100644
>> --- a/src/Text.h
>> +++ b/src/Text.h
>> @@ -15,18 +15,18 @@
>>  #define TEXT_H
>>  
>>  #include "DocIterator.h"
>> +#include "Paragraph.h"
>>  #include "ParagraphList.h"
> 
> Look suspicious.

Thanks, I removed these too, forward declarations are enough.


Yuriy


More information about the lyx-devel mailing list