Refactoring patches
Pavel Sanda
sanda at lyx.org
Thu Oct 15 22:23:19 UTC 2020
On Thu, Oct 15, 2020 at 07:57:50PM +0300, Yuriy Skalko wrote:
> > 1, 2, 9 are good to go.
>
> Committed these.
>
> > For 8 I do not understand the +#include "insets/Inset.h" part yet.
>
> Since CutAndPaste.h depends on Inset. It was included from Clipboard.h,
> that includes it from Cursor.h, that includes it from DocIterator.h,
> that includes it from CursorSlice.h that includes it finally from
> Inset.h. Yes, it was deep enough :)
I see, good :)
> > For the .cpp patches, by "manual" you mean that you checked that
> > the structures in deleted includes are not used in the .cpp file?
>
> Yes.
In that case please commit the omitted patches as well.
Pavel
More information about the lyx-devel
mailing list