[PATCH] Refactoring based on cppcheck suggestions

Jean-Marc Lasgouttes lasgouttes at lyx.org
Mon Oct 5 12:52:19 UTC 2020


Le 05/10/2020 à 13:03, Yuriy Skalko a écrit :
> I assume that if numberofcells is 0 there cannot be 0-th cell, but it
> still worth to change the code. Another question is why to bother with
> unsigned's usage at all? In my experience unsigned types are only useful
> for flag values when definitely will be no arithmetic on such values. Qt
> also try to minimize usage of unsigned types.
> 
> As I ran static analyzers on LyX code, there are many warnings on
> implicit signed-unsigned conversions in expressions.

C++ stl uses unsigned for vector indices.

JMarc


More information about the lyx-devel mailing list