[PATCH] Add override specifier

Yuriy Skalko yuriy.skalko at gmail.com
Fri Oct 2 17:53:36 UTC 2020


> I just did that and see that many files have now been handled, probably because cppcheck did not warn about Qt headers: GuiView.h, GuiWorkArea.h...
> 
> 
> Here is a log file for your enjoyment.
> 
> I'll try to handle the boost part by updating our local copy to the latest version 1.74 (which fixes this issue).
> 
> 
> A solution to avoid issues with older systems where system boost is not the latest would be to limit the introduction of -Wsuggest-override to gcc 10 and upper (I do gcc 5+ for now). Clang has its own limited version which is on by default.
> 
> 
> JMarc

Here is an updated patch.

Yes, there are more places to add the `override`. I'll try to change the
rest on the second step. Is it OK to commit the patch in its current state?

Yuriy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-override-specifiers-to-improve-code-maintainabil.zip
Type: application/octet-stream
Size: 50800 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201002/32a7f935/attachment-0001.obj>


More information about the lyx-devel mailing list