[PATCH] Add override specifier

[Jean-Marc Lasgouttes]

Le 02/10/2020 à 15:39, Jean-Marc Lasgouttes a écrit :
> Le 02/10/2020 à 15:08, Jean-Marc Lasgouttes a écrit :
>> A few remarks
>> * there are places with a double space before 'override'
>> * it does not make sense to keep 'virtual' when overriding.
>>
>> Could you fix these issues and make the commit message a bit more 
>> consistent about why we do that?
>>
>> On my side, I will add the warning -Wsuggest-override to gcc options.
> 
> I just did that and see that many files have now been handled, probably 
> because cppcheck did not warn about Qt headers: GuiView.h, GuiWorkArea.h...
> 
> Here is a log file for your enjoyment.
> 
> I'll try to handle the boost part by updating our local copy to the 
> latest version 1.74 (which fixes this issue).

Actually, boost 1.74 only uses override in a handful of cases. Not worth 
updating now.

Therefore, it does not seem doable to use -Wsuggest-override with gcc.

JMarc