[PATCH] Add override specifier

[Jean-Marc Lasgouttes]

Le 02/10/2020 à 15:08, Jean-Marc Lasgouttes a écrit :
> A few remarks
> * there are places with a double space before 'override'
> * it does not make sense to keep 'virtual' when overriding.
> 
> Could you fix these issues and make the commit message a bit more 
> consistent about why we do that?
> 
> On my side, I will add the warning -Wsuggest-override to gcc options.

I just did that and see that many files have now been handled, probably 
because cppcheck did not warn about Qt headers: GuiView.h, GuiWorkArea.h...

Here is a log file for your enjoyment.

I'll try to handle the boost part by updating our local copy to the 
latest version 1.74 (which fixes this issue).

A solution to avoid issues with older systems where system boost is not 
the latest would be to limit the introduction of -Wsuggest-override to 
gcc 10 and upper (I do gcc 5+ for now). Clang has its own limited 
version which is on by default.

JMarc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Enable-Wsuggest-override-when-warnings-are-on-with-g.patch
Type: text/x-patch
Size: 1194 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201002/151f141b/attachment.bin>