[PATCH] Add override specifier

Jean-Marc Lasgouttes lasgouttes at lyx.org
Fri Oct 2 13:08:13 UTC 2020


Le 01/10/2020 à 20:40, Yuriy Skalko a écrit :
> Hello,
> 
> I've added `override` specifiers into the LyX codebase. This will
> improve code maintainability in future. To find overridden methods I've
> used the Cppcheck static analyzer. Probably some are missed and should
> be marked later.
> 
> Jean-Marc already marked some of such methods in commit c8f4b684, I've
> continued this job.

Good idea Yuriy!

A few remarks
* there are places with a double space before 'override'
* it does not make sense to keep 'virtual' when overriding.

Could you fix these issues and make the commit message a bit more 
consistent about why we do that?

On my side, I will add the warning -Wsuggest-override to gcc options.

JMarc


More information about the lyx-devel mailing list