[LyX/master] Remove deprecated enum value with Qt5

[José Abílio Matos]

On Friday, November 27, 2020 8:57:52 AM WET Jean-Marc Lasgouttes wrote:
> +#if (QT_VERSION < 0x050000)
>         case Qt::ImMicroFocus: {
> +#else
> +       case Qt::ImCursorRectangle: {
> +#endif

This remark has nothing to do with your patch. :-)

The reason why I am raising this is to ask if we have any guideline or even 
preference. :-)

In cases like this and in terms of style I prefer to let the most recent 
option above.

In this case particularly it would mean:

+#if (QT_VERSION >= 0x050000)
+       case Qt::ImCursorRectangle: {
+#else
        case Qt::ImMicroFocus: {
+#endif

The rationale is that when the code is removed the option that stays is the 
one on top.

I admit that this is picky and I am not offended in any way with each style. I 
would just like to ask what is your opinion or even if you do not care. :-)

Regards,
-- 
José Abílio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201127/e3486922/attachment.html>