[LyX/master] Add default TransformID enum value

[Jean-Marc Lasgouttes]

Le 25/11/2020 à 01:14, Yuriy Skalko a écrit :
> commit fe0ea7bff7d89a4edaec83a272769281d39695d2
> Author: Yuriy Skalko <yuriy.skalko at gmail.com>
> Date:   Tue Nov 24 20:46:49 2020 +0200
> 
>      Add default TransformID enum value

Now I get this warning (with gcc 5.4, if it matters):

../../master/src/insets/ExternalSupport.cpp: In function ‘const string 
lyx::external::{anonymous}::substituteIt(const string&, 
lyx::external::TransformID, const string&, const 
lyx::external::Template::Format&, const lyx::InsetExternalParams&) [with 
TransformType = lyx::external::TransformOption; std::__cxx11::string = 
std::__cxx11::basic_string<char>]’:
../../master/src/insets/ExternalSupport.cpp:470:9: warning: enumeration 
value ‘None’ not handled in switch [-Wswitch]
   switch (id) {
          ^

JMarc

> ---
>   src/insets/ExternalTemplate.cpp |    2 +-
>   src/insets/ExternalTransforms.h |    1 +
>   2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/insets/ExternalTemplate.cpp b/src/insets/ExternalTemplate.cpp
> index 02f4e87..e7eca8b 100644
> --- a/src/insets/ExternalTemplate.cpp
> +++ b/src/insets/ExternalTemplate.cpp
> @@ -36,7 +36,7 @@ typedef Translator<TransformID, string> TransformIDTranslator;
>   
>   static TransformIDTranslator const initIDTranslator()
>   {
> -	TransformIDTranslator translator(TransformID(-1), "");
> +	TransformIDTranslator translator(None, "");
>   	translator.addPair(Rotate, "Rotate");
>   	translator.addPair(Resize, "Resize");
>   	translator.addPair(Clip,   "Clip");
> diff --git a/src/insets/ExternalTransforms.h b/src/insets/ExternalTransforms.h
> index 62e3342..2311ac2 100644
> --- a/src/insets/ExternalTransforms.h
> +++ b/src/insets/ExternalTransforms.h
> @@ -307,6 +307,7 @@ std::string const sanitizeDocBookOption(std::string const & input);
>   
>   
>   enum TransformID {
> +	None = -1,
>   	Rotate,
>   	Resize,
>   	Clip,
>