Patches to review

[Richard Kimberly Heck]

On 11/24/20 4:55 PM, Pavel Sanda wrote:
> On Tue, Nov 24, 2020 at 04:49:59PM -0500, Richard Kimberly Heck wrote:
>> On 11/24/20 4:29 PM, Yuriy Skalko wrote:
>>> As for the patch 5, these null pointer dereferences happen even on opening
>>> LyX manuals. It is undefined behavior even if it doesn't crash LyX. Most
>>> likely should be fixed somewhere instead of just checking.
>> 1-4 are fine. I'll have a look at the null pointer issue.
> I do not like the removal of debug.h.
> It's very handy to be able to simply lyxerr while debuging
> without playing with includes...

I guess that one is pretty cheap, yes?

Riki