New Patches

Jean-Marc Lasgouttes lasgouttes at lyx.org
Thu Nov 19 14:23:14 UTC 2020


Le 19/11/2020 à 14:54, Pavel Sanda a écrit :
> On Thu, Nov 19, 2020 at 02:09:08PM +0200, Yuriy Skalko wrote:
>> New patches for LyX.
> 
> Patch 1 looks good to go, I am not sure about the sencond, i.e.
> to what extent we want to use lambdas. IIRC some people complained
> about readability (OTOH constructs like firster are not that nice
> either). Anyway, other might want to comment on this.

I have to say that lambdas are not my cup of tea, but the original code 
is not great either. Considering the following:

  	transform(lyxaction.func_begin(), lyxaction.func_end(),
-		back_inserter(commands_), firster());
+			  back_inserter(commands_),
+			  [](auto const & p) { return p.first; });

code with boost adaptors would loo like

for (string const & cmd : lyxaction | boost::adaptors::map_keys)
	commands_.back_insert(cmd);

JMarc



More information about the lyx-devel mailing list