[LyX/master] DocBook: implement svglobal.

[Scott Kostyshak]

On Tue, Nov 17, 2020 at 09:16:04PM +0100, Thibaut Cuvelier wrote:
> On Tue, 17 Nov 2020 at 19:06, Kornel Benko <kornel at lyx.org> wrote:
> 
> > Am Tue, 17 Nov 2020 11:53:25 -0500
> > schrieb Scott Kostyshak <skostysh at lyx.org>:
> >
> > > On Mon, Nov 16, 2020 at 07:46:12PM +0100, Thibaut Cuvelier wrote:
> > > > commit c6fe1fbe5fbf93cfdef73d52423d61fb72047d88
> > > > Author: Thibaut Cuvelier <tcuvelier at lyx.org>
> > > > Date:   Mon Nov 16 20:15:34 2020 +0100
> > > >
> > > >     DocBook: implement svglobal.
> > > > ---
> > > >  development/autotests/invertedTests  |    4 +++-
> > > >  development/autotests/suspendedTests |   10 +++++++++-
> > > >  lib/layouts/svcommon.inc             |    7 ++++++-
> > > >  lib/layouts/svglobal.layout          |   15 +++++++++++++++
> > > >  lib/layouts/svglobal3.layout         |   14 ++++++++++++++
> > > >  src/output_docbook.cpp               |    7 ++++---
> > > >  6 files changed, 51 insertions(+), 6 deletions(-)
> > >
> > > I'm not sure if it was this commit or a different recent one, but now a
> > bunch of the
> > > Springers_Global_Template tests are failing.
> > >
> > > To reproduce manually, open
> > > lib/templates/Articles/Springers_Global_Journal_Template_%28V._3%29.lyx
> > on the terminal
> > > and look at the warnings. I get the following:
> > >
> > > $ lyx
> > lib/templates/Articles/Springers_Global_Journal_Template_%28V._3%29.lyx
> > > LyX: Unknown InsetLayout tag [around line 67 of
> > > file /tmp/lyx_tmpdir.OHpSZAHguvwA/converturdJfp.layout current token:
> > 'DocBookInInfo'
> > > context: ''] LyX: Unknown InsetLayout tag [around line 68 of
> > > file /tmp/lyx_tmpdir.OHpSZAHguvwA/converturdJfp.layout current token:
> > 'always' context:
> > > ''] LyX: Unknown InsetLayout tag [around line 78 of
> > > file /tmp/lyx_tmpdir.OHpSZAHguvwA/converturdJfp.layout current token:
> > 'DocBookInInfo'
> > > context: ''] LyX: Unknown InsetLayout tag [around line 79 of
> > > file /tmp/lyx_tmpdir.OHpSZAHguvwA/converturdJfp.layout current token:
> > 'always' context:
> > > ''] LyX: Unknown InsetLayout tag [around line 95 of
> > > file /tmp/lyx_tmpdir.OHpSZAHguvwA/converturdJfp.layout current token:
> > 'DocBookInInfo'
> > > context: ''] LyX: Unknown InsetLayout tag [around line 96 of
> > > file /tmp/lyx_tmpdir.OHpSZAHguvwA/converturdJfp.layout current token:
> > 'always' context:
> > > '']
> > >
> > > Scott
> >
> > Missing in src/insets/InsetLayout.cpp:133 ff?
> >
> 
> Thanks for having a look at that! I am currently enhancing quite a bit the
> Springer layouts (DocBook-wise) with new features on the C++ side,

Nice!

> but
> that's still a work in progress… It should be fixed in my WIP patch, but
> it's too WIP for pushing right now…

Good to know. Can you revert this commit then and then put it back in when your patch is ready?

Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201117/36a6ceb0/attachment.asc>