[Patch] Test suite for compare function

Kornel Benko kornel at lyx.org
Fri Nov 13 11:12:31 UTC 2020


Am Fri, 13 Nov 2020 21:11:07 +1300
schrieb "Sam Crawley" <sam at crawley.nz>:

> I've attached an updated patchset.
> 
> As discussed, there's now a different parameter for "dialog-show compare" called
> "run-blocking", which is appropriate for calling from the command line. The tests now
> use this. A couple of other things tidied up too.
> 
> Thanks,
> Sam.
> 
> On Sun, 8 Nov 2020, at 17:14, Sam Crawley wrote:
> > Hi all,
> > 
> > I've created a fairly basic test suite for the Compare function. It uses the
> > lyx_batch.pl script to run compare on two files, and then does a comparison with an
> > expected diff file.
> > 
> > This is the first step in some changes I'd like to make to the compare function (see
> > #6889).
> > 
> > Comments welcome, and also happy to have suggestions for additional test cases.
> > 
> > Thanks,
> > Sam.

Running the test I get:
...
Can't exec "/usr2/src/lyx/lyx-git/development/batchtests/bin/compare_custom.pl":
Permission denied at /BUILD/BUILDMint18/BuildLyxGitQt5.9.5local-gcc8.4.0/lyx_batch.pl
line 195.
...

The attached diff to your lyx_batch.pl.in cures it.

Another idea is making compare_custom.pl a module.

	Kornel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lyx_batch.pl.in.patch
Type: text/x-patch
Size: 1064 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201113/04b732c2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201113/04b732c2/attachment.asc>


More information about the lyx-devel mailing list