[Patch] Test suite for compare function
Scott Kostyshak
skostysh at lyx.org
Sun Nov 8 19:43:29 UTC 2020
On Sun, Nov 08, 2020 at 12:48:11PM -0500, Richard Kimberly Heck wrote:
> On 11/8/20 12:12 PM, Scott Kostyshak wrote:
> > On Sun, Nov 08, 2020 at 11:32:59AM +0100, Pavel Sanda wrote:
> >> Scott/Kornel will presumably review/check the testing part.
> > I don't have much time to review or help, although I would be happy to take a look in the future (possibly not for a while though). Thanks to Pavel and Kornel for giving comments, and thanks to Sam for jumping down this rabbit hole!
>
> Agreed. This code needs some TLC.
>
> Can I make one suggestion about how to improve it? As it is now, it
> compares files character by character. This can lead, in my experience,
> to some weird and hard to read diffs. Would it be possible to adapt it
> so that it could also read word by word where those are, say, split by
> whitespace? I know that in some languages that would not make sense, so
> this could be a choice the user could make.
I agree, that would be a really nice improvement. I think that's Sam's main motivation for working on this (https://www.lyx.org/trac/ticket/6889#comment:24).
Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.lyx.org/pipermail/lyx-devel/attachments/20201108/76193e1b/attachment-0001.asc>
More information about the lyx-devel
mailing list